Make TasksApplication.gui expect an IGUI interface, not a GUI instance #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 28, 2020 12:40
because the TasksApplication expects it's gui trait to be an instance of GUI object and not an object that supports the IGUI interface modified: envisage/ui/tasks/tests/test_tasks_application.py
Not Instance GUI modified: envisage/ui/tasks/tasks_application.py modified: envisage/ui/tasks/tests/test_tasks_application.py
and remove an unused import modified: envisage/ui/tasks/tests/test_tasks_application.py
modified: envisage/ui/tasks/tests/test_tasks_application.py
mdickinson
reviewed
Sep 1, 2020
mdickinson
reviewed
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is already how the
GUIApplicationbehaves. I'm not sure why theTasksApplicationbehaved differently earlier.envisage/envisage/ui/gui_application.py
Lines 43 to 44 in 8eddfc4