Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial flake8 fixes for envisage.ui.single_project #328

Closed
wants to merge 8 commits into from

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Oct 21, 2020

These are all the trivial flake8 fixes I have done before I realized that the package may be scheduled for removal (see #266).

They are pretty easy to do. If the flake8 fixes don't go in, we might still want to update setup.cfg to reference #269 anyway.

@kitchoi
Copy link
Contributor Author

kitchoi commented Oct 21, 2020

@rahulporuri Should I close this and just update the setup.cfg with a reference separately or is this easy enough to be reviewed?

@rahulporuri
Copy link
Contributor

It's easy enough to be reviewed but it'll just be one more commit before we possibly remove all of the code. I'm sorry for the confusion but it might just be better to discuss #327 and then update setup.cfg or any other solution.

@kitchoi
Copy link
Contributor Author

kitchoi commented Oct 21, 2020

No problem. I did not spend a lot of time on actually flaking the thing: I spent more time understanding the issues surrounding whether single_project can be removed, which is probably worthwhile anyway.
Closing (I don't want to let PRs go stale, especially ones that touch a lot of files, it is easy to restore if needed).

@kitchoi kitchoi closed this Oct 21, 2020
@kitchoi kitchoi deleted the flake8-envisage-ui-single-project branch October 21, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants