MAINT: Require VTK 9+ #1329
MAINT: Require VTK 9+ #1329
Conversation
|
Yikes unhashable type issues 😱 I'll have to figure out how they used to be hashed |
* upstream/master: More fixes to get builds working. MAINT: Fix various VTK-9.4 related issues. BUG: Fix issue with vtkGenericCell.GetCellFaces.
|
@prabhuramachandran okay to make the minimum VTK 9+? It is over 4 years old now, and the last 8.x release on PyPI only has wheels up through 3.7, which we don't even support anymore. |
|
We would get even more cleanups if we required Python 3.10 and VTK 9.2 (2 years old) or at least VTK 9.1 (3 years old), but for now we at least get some by requiring VTK 9+ (4 years old). |
|
Looks like in practice 9.1 segfaults: https://github.com/enthought/mayavi/actions/runs/12400488425/job/34617800910?pr=1329 |
| groups: | ||
| actions: | ||
| patterns: | ||
| - "*" |
There was a problem hiding this comment.
Noticed this repo didn't have one of these but it's very convenient to have. It'll tend to run CIs once a month or every couple of months which is nice to have to check in. Not to mention actually having the actions stay up-to-date :)
|
Okay I think this one should be ready @prabhuramachandran ! |
I am not sure if there are any Enthought internal projects using older VTK. @dpinte, @mdickinson -- what do you think? Can we start requiring VTK 9+ and also Python 3.10? Thanks. |
|
I think @dpinte is on leave but he did tell me that it is OK to move ahead. In any case for older versions, there are older releases of Mayavi. |
|
@larsoner -- should I disable the required statuses before merging here? |
|
@larsoner -- I will merge this for now, perhaps you can adjust the required tests if you have the permissions or let me know which ones you recommend that we keep. |
|
@prabhuramachandran I don't have permissions to change the branch protection rules, but I would just set them to the set of runs that were in this PR when it was merged |
Workaround for https://gitlab.kitware.com/vtk/vtk/-/issues/19562, but also pin fixes to a max version so that over time hopefully the shims die.
Speaking of which, it might be worth adding a min pin on VTK. Some code could be cleaned up by depending on vtk 9+, which is four years old now. Same thing with dropping Python 3.9, which most projects have done nowadays. Happy to add those here if desired.
EDIT: Also restructures CIs explicitly to use latest VTK + NumPy + Qt bindings (preferring official PySide6) available, and comments about old ones.