Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration with Traits 6.0 #632

Closed
kitchoi opened this issue Jul 24, 2020 · 1 comment · Fixed by #656
Closed

Continuous integration with Traits 6.0 #632

kitchoi opened this issue Jul 24, 2020 · 1 comment · Fixed by #656
Assignees

Comments

@kitchoi
Copy link
Contributor

kitchoi commented Jul 24, 2020

Similar to enthought/traitsui#1054

By setting up a CI job against Traits 6.0, we make sure we don't accidentally force projects to upgrade due to dependencies on existing features.

New features can depend on Traits 6.1+ and we can skip tests requiring it in the job with Traits 6.0, i.e. essentially treating Traits 6.1 as an optional dependency. Then downstream projects will have breathing space to opt-in rather than being forced to upgrade.

@kitchoi
Copy link
Contributor Author

kitchoi commented Aug 4, 2020

There are quite a few pending PRs that introduce dependencies on Traits 6.1: Imports will fail because those modules import traits.api import observe.
There are already code on master that have this problem, so this will need to be dealt with anyway. We just need to coordinate the PRs a bit. I will see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant