-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI job targeting Traits 6.0 #656
Conversation
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
==========================================
+ Coverage 39.23% 39.26% +0.02%
==========================================
Files 491 491
Lines 26899 26910 +11
Branches 4065 4065
==========================================
+ Hits 10555 10566 +11
Misses 15890 15890
Partials 454 454
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two small questions.
Added "wx" to the job. For the record, I did not add all the Qt backends because I think running just one of the Qt backends would achieve the same protection for the compatibility with Traits 6.0, compared to running all of the Qt backends. Then the choice of |
still LGTM |
Closes #632
This PR adds a CI job to test against Traits 6.0.
Tests for the data views are skipped and associated imports requiring
traits.api.observe
are wrapped in a condition (in tests only).Data view is a new feature not yet released so it is okay for it to depend on Traits 6.1 as downstream projects can opt-in.