Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job targeting Traits 6.0 #656

Merged
merged 6 commits into from
Aug 5, 2020
Merged

Add CI job targeting Traits 6.0 #656

merged 6 commits into from
Aug 5, 2020

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Aug 4, 2020

Closes #632

This PR adds a CI job to test against Traits 6.0.

Tests for the data views are skipped and associated imports requiring traits.api.observe are wrapped in a condition (in tests only).
Data view is a new feature not yet released so it is okay for it to depend on Traits 6.1 as downstream projects can opt-in.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2020

Codecov Report

Merging #656 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   39.23%   39.26%   +0.02%     
==========================================
  Files         491      491              
  Lines       26899    26910      +11     
  Branches     4065     4065              
==========================================
+ Hits        10555    10566      +11     
  Misses      15890    15890              
  Partials      454      454              
Impacted Files Coverage Δ
pyface/__init__.py 82.60% <ø> (ø)
pyface/util/testing.py 89.47% <100.00%> (+4.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0a0bd...273b3b5. Read the comment docs.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two small questions.

.travis.yml Outdated Show resolved Hide resolved
@kitchoi
Copy link
Contributor Author

kitchoi commented Aug 5, 2020

Added "wx" to the job.

For the record, I did not add all the Qt backends because I think running just one of the Qt backends would achieve the same protection for the compatibility with Traits 6.0, compared to running all of the Qt backends. Then the choice of pyqt5 among pyqt and pyside2 is somewhat arbitrary.

@rahulporuri
Copy link
Contributor

still LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous integration with Traits 6.0
3 participants