Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve standard dialog examples and documentation #1053

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Improve standard dialog examples and documentation #1053

merged 3 commits into from
Dec 13, 2021

Conversation

corranwebster
Copy link
Contributor

This PR:

  • moves dialog examples to a subdirectory of the examples
  • adds examples of file and directory dialog usage
  • adds documentation about standard dialogs
  • some minor clean-up of comments/docstrings

Fixes #1014

rahulporuri
rahulporuri approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor corrections. Note that I didn't check the built docs.

docs/source/standard_dialogs.rst Outdated Show resolved Hide resolved
docs/source/standard_dialogs.rst Outdated Show resolved Hide resolved
docs/source/standard_dialogs.rst Outdated Show resolved Hide resolved
docs/source/standard_dialogs.rst Outdated Show resolved Hide resolved
docs/source/standard_dialogs.rst Outdated Show resolved Hide resolved
corranwebster and others added 2 commits December 9, 2021 09:15
@corranwebster
Apply suggestions from code review
cff7886 
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
@corranwebster
Merge branch 'main' into doc/standard-dialogs
efe297c
@corranwebster corranwebster merged commit f797194 into main Dec 13, 2021
@corranwebster corranwebster deleted the doc/standard-dialogs branch December 13, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify intended use pattern for ProgressDialog
2 participants
@corranwebster @rahulporuri