Font dialog #1060
Merged
Font dialog #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flongford
reviewed
Jan 25, 2022
There was a problem hiding this comment.
@corranwebster - this may be a bit of a shallow review but I've pulled the branch, ran the unit tests locally on MacOS (qt5) and also tested the example code provide.
Everything seems to be working as expected, so I just have a couple of minor questions.
Let me know if there is an other area that would be beneficial to focus on
|
Getting failures from MacOS/PySide6. Need to look into it. |
This is a fairly simple PR, so there isn't much else to it (the heavy lifting is already in place). I think everything is addressed and we have tests back to working state, so this just needs merge approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a standard font selection dialog class that works with
Fontclasses.This requires #1042 to be merged first.
Fixes #1080