Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map menu coordinates to global before showing #1137

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Map menu coordinates to global before showing #1137

merged 1 commit into from
Jun 30, 2022

Conversation

corranwebster
Copy link
Contributor

Fixes #1124.

@corranwebster corranwebster marked this pull request as ready for review June 21, 2022 12:05
mdickinson
mdickinson approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster corranwebster merged commit bdc80a3 into main Jun 30, 2022
@corranwebster corranwebster deleted the fix/popup-menu-position branch June 30, 2022 09:34
corranwebster added a commit that referenced this pull request Jun 30, 2022
@corranwebster
Map menu coordinates to global before showing. (#1137)
38aa5b6
corranwebster added a commit that referenced this pull request Jul 11, 2022
@corranwebster
Map menu coordinates to global before showing. (#1137)
61f8454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double check implementation of pyface widget context menu position
2 participants
@corranwebster @mdickinson