Find correct default image for AboutDialog
#1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the Image trait can find the about.png file in pyface/images
rahulporuri
approved these changes
Jul 7, 2022
corranwebster
added a commit
that referenced
this pull request
Jul 8, 2022
* Add a test that fails because image is not loaded correctly. * Move AboutDialog trait definitions to mixin class. This ensures that the Image trait can find the about.png file in pyface/images * Fix flake8 issues.
corranwebster
added a commit
that referenced
this pull request
Jul 11, 2022
* Add a test that fails because image is not loaded correctly. * Move AboutDialog trait definitions to mixin class. This ensures that the Image trait can find the about.png file in pyface/images * Fix flake8 issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the trait definitions to the mixin class, which means that the
Imagetrait is in the right context to find the about image.Fixes #1125.