BUG: Remove cycle on cleanup. #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar results occur for PySide2, but not on PyQt5. (And yes, thanks @mdickinson for mdickinson/refcycle. Lifesaver.) |
corranwebster
pushed a commit
that referenced
this pull request
Jul 7, 2022
corranwebster
pushed a commit
that referenced
this pull request
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cycle does not appear to matter on PyQt5, but will persist in PySide2 and PySide6.
This cleanup is required in order to port Mayavi to PySide6, at least without adding more test skips for Mayavi tests that try to determine if forgetting about
DecoratedSceneobjects (which make toolbars) doesn't leave cycles.I could add tests here if we wanted to introduce
gc-using tests to pyface.