Use exec instead of exec_ where possible for Qt
#1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses hasattr to test for whether `exec` is available, which should be all Qt backends except PySide2.
rahulporuri
approved these changes
Mar 9, 2023
| if qt_api == 'pyside2': | ||
| retval = self.control.exec_() | ||
| else: | ||
| retval = self.control.exec() |
There was a problem hiding this comment.
any particular reason why we're not using hasattr here?
There was a problem hiding this comment.
No - I did it that way first and then converted to hasattr but I clearly missed one.
|
This PR is good but we're seeing one more deprecating warning for but that's a separate concern. |
|
i've created the traitsui issue enthought/traitsui#1987 mirroring this issue in pyface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
hasattrto test whetherexecis available, which should be all Qt backends except PySide2.Fixes #1179 and is more complete than #1198