Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed copyright upper bound #573

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Fixed copyright upper bound #573

merged 1 commit into from
Jul 14, 2020

Conversation

aaronayres35
Copy link
Contributor

@aaronayres35 aaronayres35 commented Jul 14, 2020

fixes #567

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Look Good To Me (LGTM).

@rahulporuri
Copy link
Contributor

@aaronayres35 fixes is one of the special words that github uses to automatically link Issues with Pull Requests (PRs). See full list of special words here - https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword . Using that special word with the issue number, in this case #567 , means that when this PR gets merged, the issue will automatically get closed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #573 into master will increase coverage by 0.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   37.98%   38.97%   +0.98%     
==========================================
  Files         470      487      +17     
  Lines       26180    26800     +620     
  Branches     3977     4066      +89     
==========================================
+ Hits         9945    10445     +500     
- Misses      15795    15899     +104     
- Partials      440      456      +16     
Impacted Files Coverage Δ
pyface/ui/qt4/about_dialog.py 84.44% <ø> (ø)
pyface/data_view/abstract_value_type.py 100.00% <0.00%> (ø)
pyface/data_view/value_types/constant_value.py 100.00% <0.00%> (ø)
pyface/ui/qt4/data_view/data_view_item_model.py 49.06% <0.00%> (ø)
pyface/ui/wx/data_view/data_view_model.py 56.36% <0.00%> (ø)
pyface/data_view/abstract_data_model.py 93.33% <0.00%> (ø)
pyface/data_view/i_data_view_widget.py 95.00% <0.00%> (ø)
pyface/data_view/value_types/no_value.py 100.00% <0.00%> (ø)
pyface/data_view/value_types/text_value.py 100.00% <0.00%> (ø)
pyface/data_view/data_view_widget.py 100.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac2c30...b15dc72. Read the comment docs.

@rahulporuri
Copy link
Contributor

@aaronayres35 once the Pull Request (PR) is Green (i.e. "All checks have passed") and the PR has been approved, the author of the PR usually merges the PR. Once you merge the PR, you will also need to manually delete the branch.

@aaronayres35 aaronayres35 merged commit b1d09c7 into master Jul 14, 2020
@aaronayres35 aaronayres35 deleted the first-branch branch July 14, 2020 17:46
@mdickinson
Copy link
Member

Once you merge the PR, you will also need to manually delete the branch.

I've changed the settings on this repository so that branches are automatically deleted at merge time.

@kitchoi kitchoi added this to the Release 7.0.1 milestone Jul 15, 2020
rahulporuri pushed a commit that referenced this pull request Jul 15, 2020
Fixed copyright upper bound

(cherry picked from commit b1d09c7)
rahulporuri pushed a commit that referenced this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copyright date in about dialog is out of date
5 participants