Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning at compile time #788

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Oct 28, 2020

This PR resolves the following deprecation warning.

/Users/kchoi/.edm/envs/my_env/lib/python3.6/site-packages/pyface/__init__.py:77: DeprecationWarning: invalid escape sequence \.
  exclusion_patterns.append("\.data_view\.")

Such warnings are even harder to spot than import time deprecation warning: They only occur the first time the Python file is byte-compiled, usually when the distribution is freshly installed.

The particular line being changed will be removed for #781. But this PR alone is justified and can be backported for bug fix releases.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitchoi kitchoi merged commit 7d0c9b4 into master Oct 29, 2020
@kitchoi kitchoi deleted the fix-deprecation-warning branch October 29, 2020 09:02
@kitchoi kitchoi added the need backport to 7.1 PRs that need to be backported to maint/7.1 label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need backport to 7.1 PRs that need to be backported to maint/7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants