Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code formatting in timers docs #794

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented Nov 6, 2020

fixes #793

This PR fixes code formatting in timers docs. The issue was the use of : and :: before the code block declaration.

fix-docs-formatting

	modified:   docs/source/timer.rst
@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #794 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   40.80%   40.78%   -0.03%     
==========================================
  Files         508      508              
  Lines       27832    27832              
  Branches     4217     4217              
==========================================
- Hits        11357    11350       -7     
- Misses      15993    15996       +3     
- Partials      482      486       +4     
Impacted Files Coverage Δ
pyface/ui/qt4/action/menu_bar_manager.py 77.77% <0.00%> (-16.67%) ⬇️
pyface/ui/wx/system_metrics.py 89.47% <0.00%> (-10.53%) ⬇️
pyface/ui/qt4/util/modal_dialog_tester.py 86.46% <0.00%> (-3.01%) ⬇️
pyface/ui/qt4/window.py 71.17% <0.00%> (-2.71%) ⬇️
pyface/ui/qt4/application_window.py 89.28% <0.00%> (-2.39%) ⬇️
pyface/ui/qt4/tasks/editor_area_pane.py 53.67% <0.00%> (-2.21%) ⬇️
pyface/ui/qt4/tasks/advanced_editor_area_pane.py 50.86% <0.00%> (-0.87%) ⬇️
pyface/ui/qt4/tasks/split_editor_area_pane.py 64.82% <0.00%> (-0.60%) ⬇️
pyface/ui/qt4/console/console_widget.py 28.86% <0.00%> (-0.21%) ⬇️
pyface/ui/qt4/code_editor/code_widget.py 43.97% <0.00%> (+0.42%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e526b...581201b. Read the comment docs.

@corranwebster
Copy link
Contributor

I am far from a master of English grammar, but I think a single colon at the end of the preceding paragraph is better than a dash.

@rahulporuri rahulporuri merged commit 4bccc3e into master Nov 6, 2020
@rahulporuri rahulporuri deleted the fix/793-code-formatting-in-docs branch November 6, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with Python code in Timer documentation
3 participants