Fixes for PythonEditor and PythonWidget
#980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mainly kicks off the deprecation of automatic creation of the widgets in the __init__ method. This also deprecates the very old wx IPython widget.
|
Looks like the warnings are showing up in the test run output. It would be nice/cleaner if they didn't. |
Right - I forgot to adjust the test cases to avoid using auto-creation. That needs fixing. |
|
That should fix the warnings from PythonEditor/PythonWidget. I'll make a separate PR to fix any others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly kicks-off the deprecation of automatic creation of the widgets in the
__init__method.This also deprecates the very old wx IPython widget - see #979.