-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Color, RBGColor and Font traits #1022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
+ Coverage 73.05% 75.01% +1.95%
==========================================
Files 51 54 +3
Lines 6514 6488 -26
Branches 1309 1283 -26
==========================================
+ Hits 4759 4867 +108
+ Misses 1363 1251 -112
+ Partials 392 370 -22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #728
Color, RBGColor and Font traits are now deprecated with the recommendation to use
traitsui
instead.Updated API references and docstrings. Description and Default Value sections seemed out of date (and sphinx was complaining) so I just removed them. Removed all references to these traits from User manual as well.
Also updated one example that uses
RGBColor
.Checklist
docs/source/traits_api_reference
)docs/source/traits_user_manual
)[ ] Update type annotation hints intraits-stubs