Rename NoneTrait to make it private #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitchoi
changed the title
mdickinson
reviewed
May 19, 2020
| @@ -3810,7 +3810,7 @@ def as_ctrait(self): | |||
| return self.trait_maker.as_ctrait() | |||
|
|
|||
|
|
|||
| class NoneTrait(TraitType): | |||
| class _NoneTrait(TraitType): | |||
There was a problem hiding this comment.
Could we maybe take the opportunity to note in the docstring that this is primarily for use in the Either implementation?
There was a problem hiding this comment.
Gah. Union, not Either, of course.
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
- Coverage 76.15% 74.21% -1.95%
==========================================
Files 54 78 +24
Lines 6493 8469 +1976
Branches 1263 1610 +347
==========================================
+ Hits 4945 6285 +1340
- Misses 1205 1806 +601
- Partials 343 378 +35
Continue to review full report at Codecov.
|
|
Appveyor build is complaining about connection to packages.enthought.com, restarting to see if this is a temporary network problem... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1105
Checklist
Testsdocs/source/traits_api_reference): autodoc handles that.Update User manual (: never mentioneddocs/source/traits_user_manual)traits-stubs~