Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add Union to the Predefined Trait Type table #1116

Merged
merged 1 commit into from
May 19, 2020
Merged

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented May 19, 2020

Closes #1113

It is so tempting to go scan the entire list of trait types on api.py and compare that with the table, but that might be an exercise for another day.

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference)
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in traits-stubs

@kitchoi kitchoi changed the title DOC: Add Union to the Predefined Trait type table DOC: Add Union to the Predefined Trait Type table May 19, 2020
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitchoi kitchoi merged commit 8048053 into master May 19, 2020
@kitchoi kitchoi deleted the 1113-union-in-doc branch May 19, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Union is missing from the table of predefined traits
2 participants