Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename package observers to observation #1123

Merged
merged 3 commits into from
May 20, 2020
Merged

Rename package observers to observation #1123

merged 3 commits into from
May 20, 2020

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented May 20, 2020

Part of #977

This PR renames the observers package to observation.
The new name fits better with the existing adaptation.

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference)
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in traits-stubs

@kitchoi kitchoi changed the title Rename package observers -> observation Rename package observers to observation May 20, 2020
@mdickinson
Copy link
Member

Looks like the MANIFEST.in needs updating

@kitchoi
Copy link
Contributor Author

kitchoi commented May 20, 2020

Well spotted! Thanks.

@mdickinson
Copy link
Member

Also etstool.py. :-) I think that's everything.

@kitchoi
Copy link
Contributor Author

kitchoi commented May 20, 2020

Thank you!

mdickinson
mdickinson approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitchoi kitchoi merged commit 3415bbe into master May 20, 2020
@kitchoi kitchoi deleted the rename-observe-package branch May 20, 2020 11:12
@kitchoi kitchoi mentioned this pull request May 22, 2020
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitchoi @mdickinson