Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use class name in hash consistently #1129

Merged
merged 1 commit into from
May 21, 2020
Merged

Use class name in hash consistently #1129

merged 1 commit into from
May 21, 2020

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented May 21, 2020

All except two of classes in traits.observation use class names for __hash__.
This PR fixes the other two so they are consistent with others.

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference)
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in traits-stubs

mdickinson
mdickinson approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit c4504d2 into master May 21, 2020
@mdickinson mdickinson deleted the hash-class-name branch May 21, 2020 16:51
@kitchoi kitchoi mentioned this pull request May 22, 2020
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitchoi @mdickinson