Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cleanup #121

Merged
merged 20 commits into from
Jan 13, 2014
Merged

Test cleanup #121

merged 20 commits into from
Jan 13, 2014

Conversation

mdickinson
Copy link
Member

Version of PR #116, refreshed against master.

pberkes
pberkes reviewed Jan 10, 2014
View reviewed changes
integrationtests/ui/test_set_dynamic.py

batting_order = List( Str )
roster = List( [ 'Tom', 'Dick', 'Harry', 'Sally' ], Str )
class Team (HasTraits):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary space: Team (

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like pep8 doesn't pick up on that. Grr.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.12%) when pulling 1a2cb3c on test-cleanup into 325f69d on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.11%) when pulling 1a2cb3c on test-cleanup into 325f69d on master.

@rkern
Copy link
Member

rkern commented Jan 11, 2014

Most (or all ) view = View(...) should be traits_view = View(...). That might be good to get done in here.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.12%) when pulling 36324d2 on test-cleanup into 2999c77 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.11%) when pulling 3c7adcb on test-cleanup into 071dfc9 on master.

@mdickinson
Copy link
Member Author

Updated the PR against master and removed the entire integrationtests directory: these tests are all UI tests, and are duplicates of those in traitsui.

mdickinson
mdickinson reviewed Jan 12, 2014
View reviewed changes
traits/tests/test_dynamic_notifiers.py
@@ -75,46 +75,54 @@ def failing_method_listener_4(self, obj, name, old, new):
# 'ok' function listeners

calls_0 = []
calls_1 = []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to keep these definitions near the functions that use them.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.28%) when pulling 3c7adcb on test-cleanup into 071dfc9 on master.

mdickinson
mdickinson reviewed Jan 12, 2014
View reviewed changes
traits/tests/test_trait_types.py

class TraitTypesTest(unittest.TestCase):

def setUp(self):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these methods added intentionally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May have been the result of a bad merge. I'll remove them.

@mdickinson
Copy link
Member Author

@rkern:

Most (or all ) view = View(...) should be traits_view = View(...). That might be good to get done in here.

Done, sort of. I've just removed all the integration tests, since they're duplicated in TraitsUI anyway.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.59%) when pulling 272f21d on test-cleanup into 071dfc9 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.11%) when pulling 272f21d on test-cleanup into 071dfc9 on master.

@pberkes
Copy link
Contributor

pberkes commented Jan 13, 2014

Tests pass, PEP8 is happy, pyflakes is happy (as much as it can) => I'm happy
👍

pberkes pushed a commit that referenced this pull request Jan 13, 2014
Merge pull request #121 from enthought/test-cleanup
9eb1da4 
Test cleanup
@pberkes pberkes merged commit 9eb1da4 into master Jan 13, 2014
@pberkes pberkes deleted the test-cleanup branch January 13, 2014 09:17
@rahulporuri rahulporuri mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mdickinson @coveralls @rkern @pberkes @timdiller