Require Sphinx 2.1 for trait_documenter tests #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
changed the title
|
Edited the PR title to clarify that the restriction on the Sphinx version applies only to the trait documenter tests; not to trait_documenter itself. |
mdickinson
added a commit
that referenced
this pull request
Oct 21, 2020
We require Sphinx >= 2.1. Related: #1216.
mdickinson
added a commit
that referenced
this pull request
Oct 21, 2020
mdickinson
added a commit
that referenced
this pull request
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove some backwards compatibility code needed for ancient Sphinx versions.
Just to be safe, we also add a minimum Sphinx version in the test requirements.
Closes #1054.