Strengthen interface checks in tests #1225
Conversation
mdickinson
changed the title
mdickinson
added
component: test suite
|
I extended the PR to add some tests for the current interface-checking behaviour of the |
| with self.set_check_interfaces(2): | ||
| with self.assertRaises(InterfaceError): | ||
| # Simulate application of the decorator | ||
| Test = provides_ifoo(Test) |
There was a problem hiding this comment.
Is the assignment Test = necessary here?
There was a problem hiding this comment.
It's not. I'm surprised I didn't get a flake8 warning. I'll remove it, and the similar occurrence in test_provides_with_interface_check_warn.
There was a problem hiding this comment.
Though actually, it may be worth adding explicit tests that in the warning case, we do end up with something that implements IFoo, and in the error case, we don't.
There was a problem hiding this comment.
Either way sounds good to me!
There was a problem hiding this comment.
Hmm. It turns out that the extra test I added failed: even though the application of provides_ifoo fails in this case, Test still gets registered as implementing IFoo! It doesn't seem worth fixing, for something we're deprecating anyway, but now I'm not sure whether to encode the behaviour in a test or just leave it out.
On balance, I think I'll keep the extra test, but I could be persuaded otherwise.
There was a problem hiding this comment.
Extra tests added; unused variable is now used!
There was a problem hiding this comment.
Hmm. It turns out that the extra test I added failed: even though the application of provides_ifoo fails in this case, Test still gets registered as implementing IFoo! It doesn't seem worth fixing, for something we're deprecating anyway, but now I'm not sure whether to encode the behaviour in a test or just leave it out.
Yep this is surprising, and I agree that this is not worth fixing.
This PR enhances some of the tests in
test_interfaces.py:CHECK_INTERFACESis set to2.)assertIsInstancechecks to verify that instances of those test classes do pass the appropriateisinstancechecks.