Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mypy an optional dependency #1289

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Make mypy an optional dependency #1289

merged 1 commit into from
Sep 4, 2020

Conversation

mdickinson
Copy link
Member

This PR makes mypy an optional dependency for the mypy tests.

This might seem like an odd thing to do, but some test runners (notably pytest) will discover those tests. If pytest is run on a clean Python environment with a freshly-installed Traits, then it should gracefully skip the tests for which the dependencies aren't installed. We already do this for Sphinx, numpy, and various other packages.

Related: #1288

kitchoi
kitchoi approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an odd thing to do if I think of the traits-stubs distribution being eventually absorbed into traits distribution.

@mdickinson mdickinson merged commit 34eff19 into master Sep 4, 2020
@mdickinson mdickinson deleted the test/make-mypy-optional branch September 4, 2020 06:53
@mdickinson mdickinson mentioned this pull request Sep 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitchoi kitchoi kitchoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdickinson @kitchoi