Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 3.5 compatibility code #1313

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Remove Python 3.5 compatibility code #1313

merged 1 commit into from
Oct 13, 2020

Conversation

mdickinson
Copy link
Member

This is a follow-on PR to #1312. Strictly speaking, it probably shouldn't be merged until after #1312 (but the CI won't care, because we already removed the 3.5 runs).

This PR:

  • Removes some test code that needed to worry about dictionary ordering.
  • Removes conditional imports of os.fspath: with Python >= 3.6, we can assume the presence of os.fspath.

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference)
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in traits-stubs

rahulporuri
rahulporuri approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 9b22486 into master Oct 13, 2020
@mdickinson mdickinson deleted the cleanup/python35-compatibility branch October 13, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdickinson @rahulporuri