Document fvalidate #132
Merged
Document fvalidate #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| All parameters are optional, including the *fget* "getter", *fvalidate* | ||
| "validator" and *fset* "setter" methods. If no parameters are specified, then | ||
| the trait looks for and uses methods on the same class as the attribute that | ||
| the trait is assigned to, with |
There was a problem hiding this comment.
Very minor nit: short line.
| "validator" and *fset* "setter" methods. If no parameters are specified, then | ||
| the trait looks for and uses methods on the same class as the attribute that | ||
| the trait is assigned to, with names of the form _get_\ *name*\ () _validate_\ | ||
| () *name*\ and _set_\ *name*\ (), where *name* is the name of the trait |
There was a problem hiding this comment.
Should it be _validate_\ *name\ () instead of _validate_\ () *name*\? It would also be good to have a comma between _get_... and _validate_.... Sorry for not noticing this the first time.
|
it this ready to merge? |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some basic documentation for the Property
validatormethods