Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for the use case of Trait with mapping and callable #1336

Merged
merged 5 commits into from
Nov 13, 2020
Merged

Add test for the use case of Trait with mapping and callable #1336

merged 5 commits into from
Nov 13, 2020

Commits on Nov 4, 2020

  1. Add a test to exercise a scenario of Trait where migration from Trait… 

    …Map to Map is difficult (or imppossible)
    @kitchoi
    kitchoi committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    3121010 View commit details
    Browse the repository at this point in the history

  2. Silence DeprecationWarning for now

    @kitchoi
    kitchoi committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    f0622a3 View commit details
    Browse the repository at this point in the history

  3. Remove redundant comment

    @kitchoi
    kitchoi committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    67f4454 View commit details
    Browse the repository at this point in the history

  4. Fix comment

    @kitchoi
    kitchoi committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    fb8768f View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Mark Dickinson <mdickinson@enthought.com>
    @kitchoi @mdickinson
    kitchoi and mdickinson authored Nov 13, 2020
    Configuration menu
    Copy the full SHA
    0680161 View commit details
    Browse the repository at this point in the history