Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Traits introduction description not being visible on etsdemo #1358

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Nov 17, 2020

Closes #1357

This PR moves the __init__.py file to an index.rst. Now the description is visible on etsdemo:
Screenshot 2020-11-17 at 10 23 33

This does NOT close #1356 (one can still import traits.examples.introduction for it is still considered a 'namespace package'?).

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference)
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in traits-stubs

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitchoi kitchoi merged commit d0b9455 into master Nov 17, 2020
@kitchoi kitchoi deleted the move-init-to-index branch November 17, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Introduction to Traits" description is not visible in etsdemo
2 participants