Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of 'adapts' and 'implements' from examples and tutorial #1367

Merged
merged 5 commits into from
Nov 24, 2020

Conversation

mdickinson
Copy link
Member

This PR purges mentions of the (no-longer-extant) functions adapts and implements from the tutorial files and documentation examples.

For adapts, we've mostly gone the way of removing the offending files altogether: the adaptation story has changed enough that the old material was too far from correct to be useful. Someday it might be nice to add an adaptation tutorial back in.

For implements, we've fixed the examples to use provides instead.

Closes #437.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit e2da551 into master Nov 24, 2020
@mdickinson mdickinson deleted the docs/remove-adapts branch November 24, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purge use of adapts/implements from the traits examples
2 participants