Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update end year for copyright headers #1376

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Conversation

mdickinson
Copy link
Member

This PR updates the end year for copyright headers to 2021 throughout the codebase.

@kitchoi
Copy link
Contributor

kitchoi commented Jan 4, 2021

I just ran into the same Sphinx error locally on OSX and Python 3.9 (probably worth an upstream issue). It is validating to see CI is experiencing the same error.

The error reads like this:

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/sphinx/util/typing.py", line 160, in _restify_py37
    return ':obj:`%s.%s`' % (cls.__module__, cls.__name__)
AttributeError: 'NoDefaultSpecified' object has no attribute '__name__'
The full traceback has been saved in /tmp/sphinx-err-wmtcdro7.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
Error: Process completed with exit code 2.

I could build the documentation by downgrading to Sphinx 3.3.1.

Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Unfortunately the documentation build error is blocking this from being merged unless one has admin privileges.

@mdickinson
Copy link
Member Author

Thanks, @kitchoi. I'm going to temporarily change the branch protection so that I can get this PR in, else every other PR will be blocked by the failing copyright check.

For the Sphinx issue, I think we need to do two things:

  • Pin the Sphinx version used for the PR CI checks (though possibly we want a cron job that uses the latest version of Sphinx, so that we can be alerted to potential issues)
  • Investigate the failure seen above, and report an upstream issue if necessary.

@kitchoi
Copy link
Contributor

kitchoi commented Jan 4, 2021

Investigate the failure seen above, and report an upstream issue if necessary.

I am on it :)

@mdickinson
Copy link
Member Author

Opened #1377 to track the doc build issue.

@mdickinson mdickinson merged commit 6e924d2 into master Jan 4, 2021
@mdickinson mdickinson deleted the update-copyright-headers branch January 4, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants