Fix bad trait declaration for a threading Lock #1411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bad Instance declaration that effectively declared that a _lock trait could only be assigned a built-in function or method (and in particular, could not be assigned a lock).
I really wanted to rename the events trait to _events too as part of this PR, but I can't be absolutely sure that it's not being used elsewhere. (And it is used in the tests, which isn't a great sign.)
No regression test, because I couldn't find a way to exercise the issue using only the public API, and I don't really want to add tests that test internal implementation details. However, if/when we deprecate Instance(some_instance), this code will now fail to give a DeprecationWarning, where the code in master would have given such.
Fixes #1408.
(Recreation of bad PR #1410)
Checklist
[ ] Update API reference (docs/source/traits_api_reference).N/A[ ] Update User manual (docs/source/traits_user_manual).N/A[ ] Update type annotation hints in traits-stubs.N/A