Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add_class_trait in the presence of subclasses #1461

Merged
merged 7 commits into from
May 17, 2021
Merged

Fix add_class_trait in the presence of subclasses #1461

merged 7 commits into from
May 17, 2021

Commits on May 12, 2021

  1. Fix that add_class_trait was broken for traits with items in the pres… 

    …ence of subclasses.
    @mdickinson
    mdickinson committed May 12, 2021
    Configuration menu
    Copy the full SHA
    0113ae4 View commit details
    Browse the repository at this point in the history

  2. Add docstring for _add_class_trait

    @mdickinson
    mdickinson committed May 12, 2021
    Configuration menu
    Copy the full SHA
    87facf5 View commit details
    Browse the repository at this point in the history

  3. Fix mutation of HasTraits class by another test.

    @mdickinson
    mdickinson committed May 12, 2021
    Configuration menu
    Copy the full SHA
    020084c View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Merge remote-tracking branch 'origin/master' into fix/add-class-trait… 

    …-has-items
    @mdickinson
    mdickinson committed May 13, 2021
    Configuration menu
    Copy the full SHA
    cb305ef View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Add tests for behaviour when the trait already exists

    @mdickinson
    mdickinson committed May 17, 2021
    Configuration menu
    Copy the full SHA
    674de0f View commit details
    Browse the repository at this point in the history

  2. More natural spelling for sort by decreasing length

    @mdickinson
    mdickinson committed May 17, 2021
    Configuration menu
    Copy the full SHA
    0b8df33 View commit details
    Browse the repository at this point in the history

  3. Update traits/has_traits.py 

    Co-authored-by: Corran Webster <cwebster@enthought.com>
    @mdickinson @corranwebster
    mdickinson and corranwebster authored May 17, 2021
    Configuration menu
    Copy the full SHA
    ee805d4 View commit details
    Browse the repository at this point in the history