Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Symbol trait type #1542

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Deprecate the Symbol trait type #1542

merged 2 commits into from
Sep 21, 2021

Conversation

mdickinson
Copy link
Member

This PR deprecates the Symbol trait type, which was untested, unused in code that I have access to (with one exception, where it can be easily replaced), and has some slightly dangerous eval-based semantics. It's also not really a good fit for a trait, since it involves neither validation nor notification.

  • Tests
  • Update API reference (docs/source/traits_api_reference)
  • [ ] Update User manual (docs/source/traits_user_manual) N/A
  • [ ] Update type annotation hints in traits-stubs N/A

Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fair bit of discussion out of band, but every use case we could think of wass better done other ways, plus this is not used anywhere that we could find.

This looks good to go.

@mdickinson mdickinson merged commit dbff21f into main Sep 21, 2021
@mdickinson mdickinson deleted the cleanup/deprecated-symbol branch September 21, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants