Deprecate acceptance of lists by Tuple traits #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
Apr 1, 2022
| @@ -73,3 +73,22 @@ class A(HasTraits): | |||
| b = A() | |||
| self.assertEqual(a.foo, (0, ("", 0))) | |||
| self.assertIs(a.foo, b.foo) | |||
|
|
|||
| def test_lists_not_accepted(self): | |||
There was a problem hiding this comment.
This is just an additional test for existing behaviour that isn't changed by this PR.
There was a problem hiding this comment.
Is it worth adding the same tests for BaseTuple as well?
There was a problem hiding this comment.
Not just yet - I'm deliberately avoiding changing the behaviour of BaseTuple at all in this PR (at least partly because we have other BaseTuple subclasses). I do plan a followup PR at some point for BaseTuple.
rahulporuri
approved these changes
Apr 1, 2022
| @@ -73,3 +73,22 @@ class A(HasTraits): | |||
| b = A() | |||
| self.assertEqual(a.foo, (0, ("", 0))) | |||
| self.assertIs(a.foo, b.foo) | |||
|
|
|||
| def test_lists_not_accepted(self): | |||
There was a problem hiding this comment.
Is it worth adding the same tests for BaseTuple as well?
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
Tupletrait type so that it only ever accepts instances of typetuple. Previously, the argument-less trait typeTuple()would accept (and coerce)listinstances in addition totupleinstances, while with arguments (e.g.,Tuple(Int(), Int()), only tuples would be accepted.Work towards #1626, but this PR doesn't change the behaviour of the
BaseTupletrait type at all.Checklist
docs/source/traits_api_reference) N/Adocs/source/traits_user_manual) N/Atraits-stubsN/A