Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type stubs for the Dict trait type #1655

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Fix type stubs for the Dict trait type #1655

merged 3 commits into from
Jun 29, 2022

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jun 24, 2022 •
edited
Loading

This PR fixes the type stubs for the Dict trait type.

Fixes #1654.

WIP: I'll see if I can add some suitable tests before asking for review.

@mdickinson mdickinson marked this pull request as ready for review June 24, 2022 14:49
@mdickinson
Copy link
Member Author

Marking as ready for review; the attempt to add more tests uncovered more problems than it solved.

corranwebster
corranwebster approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct, once I wrapped my head around it.

Not for this PR, but the metavariables _S, _T, etc. might be clearer with naming to make the accepts/stores distinction clearer.

@mdickinson
Copy link
Member Author

Not for this PR, but the metavariables _S, _T, etc. might be clearer with naming to make the accepts/stores distinction clearer.

Agreed. I think every time I look at this I'm going to have to think about it. For this PR, it may make sense to add an explanatory comment about how the metavariables are mapped.

@mdickinson
Copy link
Member Author

Explanatory comment added.

@rahulporuri
Copy link
Contributor

LGTM - I tested this branch and it fixes the issue we were seeing in our project.

@mdickinson mdickinson merged commit 80294cf into main Jun 29, 2022
@mdickinson mdickinson deleted the fix/dict-traits-stub branch June 29, 2022 15:00
mdickinson added a commit that referenced this pull request Aug 9, 2022
@mdickinson
Fix type stubs for the Dict trait type (#1655)
c135f3e 
This PR fixes the type stubs for the Dict trait type.

Fixes #1654.

(cherry picked from commit 80294cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dict type stubs are incorrect
3 participants
@mdickinson @rahulporuri @corranwebster