Minor fixes and updates in trait_types.pyi; new ctraits.pyi #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+61
to
+63
| factory: _CallableType[..., _Any] = ..., | ||
| args: _Tuple[_Any, ...] = ..., | ||
| kw: _DictType[str, _Any] = ..., |
There was a problem hiding this comment.
This would seem like a use-case for ParamSpec (but that would imply using typing-extensions for now).
There was a problem hiding this comment.
I'm not seeing how to use ParamSpec here; any suggestions?
What I'd like to do is something like:
P = ParamSpec("P")
class Any(_TraitType[_Any, _Any]):
def __init__(
self,
default_value: _Any = ...,
*,
factory: _CallableType[P, _Any] = ...,
args: P.args = ...,
kw: P.kwargs = ...,
**metadata: _Any,
) -> None:
...
But it looks as though P.args and P.kwargs can't be used this way - they can only be used in the context of *args and **kwargs.
We already have the dependence on typing-extensions, so I'm not averse to expanding that dependence.
corranwebster
approved these changes
Jul 21, 2022
Co-authored-by: Corran Webster <cwebster@enthought.com>
mdickinson
added a commit
that referenced
this pull request
Aug 9, 2022
This PR makes some minor type-stub related fixes and cleanups, as part of an incremental effort to get the stubs into a usable state. * Add suitable flake8 exclusions for type stubs (it's common to put the ... on the same line as a function def, for example; black does that, but flake8 complains about it). * Add new ctraits.pyi type stubs. It's not complete, but it's sufficient to stop complaints in some other parts of the codebase. * Fix confusion with int being both the built-in type and an enum name in ValidateTrait * Several fixes in trait_types.pyi. In particular, Pylance/Pyright doesn't like missing type variables, even though the typing documentation says that it should be okay to use e.g., plain Callable instead of Callable[..., Any]. * Fix some non-standard double indentation in the trait_types.pyi stubs. Co-authored-by: Corran Webster <cwebster@enthought.com> (cherry picked from commit 9f5fe4d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some minor type-stub related fixes and cleanups, as part of an incremental effort to get the stubs into a usable state.
...on the same line as a functiondef, for example; black does that, but flake8 complains about it).ctraits.pyitype stubs. It's not complete, but it's sufficient to stop complaints in some other parts of the codebase.intbeing both the built-in type and an enum name inValidateTraittrait_types.pyi. In particular, Pylance/Pyright doesn't like missing type variables, even though thetypingdocumentation says that it should be okay to use e.g., plainCallableinstead ofCallable[..., Any].trait_types.pyistubs.