Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HasTraits introspection with dir() #927

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

midhun-pm
Copy link
Contributor

Fix #925
Includes the names from super().__dir__() in the HasTraits.__dir__'s output.

@codecov-io
Copy link

codecov-io commented Mar 6, 2020

Codecov Report

Merging #927 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
+ Coverage   72.76%   72.95%   +0.18%     
==========================================
  Files          51       51              
  Lines        6474     6456      -18     
  Branches     1302     1301       -1     
==========================================
- Hits         4711     4710       -1     
+ Misses       1367     1347      -20     
- Partials      396      399       +3
Impacted Files Coverage Δ
traits/has_traits.py 71.24% <100%> (-0.08%) ⬇️
traits/editor_factories.py 81.25% <0%> (-3.13%) ⬇️
traits/adaptation/adaptation_offer.py 93.75% <0%> (-0.37%) ⬇️
traits/trait_set_object.py 66.89% <0%> (-0.23%) ⬇️
traits/trait_types.py 71.07% <0%> (-0.16%) ⬇️
traits/adaptation/adaptation_manager.py 98.19% <0%> (-0.05%) ⬇️
traits/testing/unittest_tools.py 96% <0%> (-0.04%) ⬇️
traits/traits.py 76.92% <0%> (+4.04%) ⬆️
traits/etsconfig/etsconfig.py 63.46% <0%> (+5.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d539c9...94faf9a. Read the comment docs.

traits/has_traits.py Outdated Show resolved Hide resolved
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll test this with Envisage before merging (we've had compatibility issues between the fancy dir and Envisage previously).

@mdickinson
Copy link
Member

Envisage seems fine: the Envisage test suite runs without error on Envisage master + Traits from this branch. Merging.

@mdickinson mdickinson merged commit 9e07f00 into master Mar 11, 2020
@mdickinson mdickinson deleted the bugfix/introspect_more_names_hastraits branch March 11, 2020 12:54
@mdickinson
Copy link
Member

Aargh. Sorry, @corranwebster: I should have waited for you to confirm that you're happy that your comments have been addressed before merging. Let me know if not, and we can revert or do a follow-up PR as appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HasTraits._notifiers method not showing up in dir()
4 participants