-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve HasTraits introspection with dir()
#927
Conversation
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
==========================================
+ Coverage 72.76% 72.95% +0.18%
==========================================
Files 51 51
Lines 6474 6456 -18
Branches 1302 1301 -1
==========================================
- Hits 4711 4710 -1
+ Misses 1367 1347 -20
- Partials 396 399 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll test this with Envisage before merging (we've had compatibility issues between the fancy dir
and Envisage previously).
Envisage seems fine: the Envisage test suite runs without error on Envisage master + Traits from this branch. Merging. |
Aargh. Sorry, @corranwebster: I should have waited for you to confirm that you're happy that your comments have been addressed before merging. Let me know if not, and we can revert or do a follow-up PR as appropriate. |
Fix #925
Includes the names from
super().__dir__()
in theHasTraits.__dir__
's output.