Fix another case of exception swallowing from PyObject_GenericGetAttr #960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an attribute is looked up on a
CTrait
object,None
is returned on failed lookup, regardless of the actual exception that was raised. This means that (for example) logic errors from aCTrait
method will be silenced.This PR changes the behaviour to only return
None
if the attribute lookup raisesAttributeError
, and to propagate any other exception.This is the
cTrait
analog to #959 forCHasTraits
.Along with #959, this fixes #946.