Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TraitList / TraitListObject #989

Merged
merged 28 commits into from
Apr 9, 2020
Merged

Refactor TraitList / TraitListObject #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
0110d33
Refactor TraitList / TraitListObject
mdickinson Apr 7, 2020
0c9e58a
Tweak element validators in tests
mdickinson Apr 7, 2020
6d62fb8
Test cleanups: add missing docstrings, don't import private function
mdickinson Apr 7, 2020
5f667a7
Simplify the _normalize_slice helper function
mdickinson Apr 7, 2020
73f5113
Fix corner-case behaviour for __iadd__ and extend
mdickinson Apr 7, 2020
65eb7d2
Expand test coverage
mdickinson Apr 7, 2020
5961216
Style; remove outdated comments
mdickinson Apr 7, 2020
0c7c746
Add tests for TraitListObject length checks
mdickinson Apr 7, 2020
a35a5e3
Add 'Raises' section to __setitem__ docstring.
mdickinson Apr 7, 2020
f779847
One more test; thin down list of TODOs
mdickinson Apr 7, 2020
4e61261
Add test that exercises the case where object_ref is a dead weakref
mdickinson Apr 7, 2020
e2234f1
Fix some manual normalized_index calculations to use existing helper …
mdickinson Apr 7, 2020
6542cbe
Remove pointless comment
mdickinson Apr 7, 2020
17bc628
Add check that clearing an empty list doesn't notify
mdickinson Apr 7, 2020
e6e5512
Add tests to cover negative steps in __delitem__ and __setitem__
mdickinson Apr 7, 2020
db98034
More coverage improvements
mdickinson Apr 7, 2020
fe59be7
Minor cleanup in extend and __iadd__
mdickinson Apr 8, 2020
fb285c5
Add minimal tests for TraitListEvent
mdickinson Apr 8, 2020
601cbc2
Fix unnecessary complication in __deepcopy__ method
mdickinson Apr 8, 2020
1fc34c8
Fix another unnecessarily complicated __deepcopy__ method
mdickinson Apr 8, 2020
b397996
Add test that verifies that copy discards notifiers
mdickinson Apr 8, 2020
1a05a88
Fix another coverage gap
mdickinson Apr 8, 2020
a321b0f
Add regression test for reverse method double notification on master
mdickinson Apr 8, 2020
63c24b6
Clarify that int_item_validator includes integer-likes
mdickinson Apr 8, 2020
5d53846
Fix occurrences of outdated 'LengthConstrainedTraitList' name
mdickinson Apr 8, 2020
8a051f7
Fix copy'n'paste pop->remove error
mdickinson Apr 8, 2020
57045e2
Fix bad length validation when multiplying by a negative integer
mdickinson Apr 8, 2020
75ef25b
Remove XXX comment about documenting event contents
mdickinson Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading