Add a CI job for testing against traits 6.0 #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed the new job is running with Traits 6.0 |
|
And currently the CI job for Wx is allowed to fail, so I also don't see much value in including wx for this new CI job. In fact, it is better to exclude wx because the job can be required to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1054
This PR adds a job for the Travis build to test against Traits 6.0.
I did not multiply the entire matrix with Traits 6.0 because I did not find this necessary. Given most of the GUI tests are skipped on Null or Wx backend, choosing one of the Qt backend exercise most logic that would depend on traits 6.1. Then the choice of PyQt5 over PySide2 is a bit arbitrary.