Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0.1 bugfix backport PR #800

Merged
merged 28 commits into from
Jul 8, 2020
Merged

7.0.1 bugfix backport PR #800

merged 28 commits into from
Jul 8, 2020

Commits on May 1, 2020

  1. Configuration menu
    Copy the full SHA
    a94fa67 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Fixes for Qt DatetimeEditor (#803)

    * Fixes for Qt DatetimeEditor.
    
    * Fix handling of changes to editor bounds.
    
    * Remove commented out code from editor example.
    
    * And remove corresponding imports.
    
    * Missed file with explicit defaults.
    
    * Fixes to min/max and value out of range handling.
    corranwebster committed May 11, 2020
    Configuration menu
    Copy the full SHA
    10f8aaf View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Remove NameError and add default root_dir to tutor.py (#813)

    * Remove NameError from tutor.py
    
    * Take current directory as default
    
    * Relax argument number constraint
    ievacerny authored and corranwebster committed May 20, 2020
    Configuration menu
    Copy the full SHA
    3dbaefb View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Rewrite nose tests to use unittest (#809)

    * Rewrite nose tests to use unittest
    
    * Rewrite remaining bare test functions
    
    * Remove print statements from unit tests
    
    * Replace assertEquals with assertEqual
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    117457c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2bec2b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d03a071 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #829 from enthought/fix/ui-panel-alignment

    Remove align centre which was causing problems
    kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    1a6ade1 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #808 from enthought/fix/demo-fixes

    A variety of fixes to the Demo app
    kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    f60aadc View commit details
    Browse the repository at this point in the history
  6. Add more tests for Enum Editor (#836)

    * Add more tests for Enum Editor
    
    * Add wx EnumEditor tests
    
    * Add missing skipif decorator
    
    * Add issue references to FIXMEs
    
    * Address review comments
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    2ffcdcc View commit details
    Browse the repository at this point in the history
  7. Add check list editor tests (#837)

    * Add check list editor tests
    
    * Add wx tests for check list editor
    
    * Simplify helper functions
    
    * Add issue references to FIXMEs
    
    * Address review comments
    
    * Don't rely on empty list behaviour with combobox editor
    
    * Add temporary fix to prevent wx test interactions
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7c9b3b7 View commit details
    Browse the repository at this point in the history
  8. Add set editor tests (#838)

    * Add set editor tests
    
    * Simplify helper functions
    
    * Add wx tests for set editor
    
    * Add issue reference to FIXME
    
    * Address review comments
    
    * Expand ordered flag tests
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    ca43ec0 View commit details
    Browse the repository at this point in the history
  9. Add image enum editor tests (#845)

    * Add tests for image enum editor
    
    * Docstring fixes
    
    * Address review comments
    
    * Skip tests that don't cleanup properly due to editor issue
    
    * Remove unreliable image_cache checks
    
    * Skip problematic tests on linux
    
    * Address review comments
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    dcd18ca View commit details
    Browse the repository at this point in the history
  10. Move value mapping from factory to individual editors (#848)

    * Move value mapping from factory to individual editors
    
    * Remove factory mapping references from image enum editor
    
    * Remove unused wx helper function
    
    * Address review comments
    
    * Remove test FIXMEs
    
    * Use instantiated tookit
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    592d028 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #850 from enthought/fix-demo-app-description-for-f…

    …older
    
    Fix Demo application description if __init__.py or traits_ui_demo.jpg are not found
    kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7a6302b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a7b6601 View commit details
    Browse the repository at this point in the history
  13. Move format_func, format_str and invalid traits from factory to editor (

    #859)
    
    * Move format_func and format_str from factory to editor
    
    * Move invalid from factory to editor as invalid_trait_name
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    8ef5755 View commit details
    Browse the repository at this point in the history
  14. Merge pull request #871 from enthought/fix/segfault-row-reorder

    FIX: Make sure new_row is positive
    kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    58e6910 View commit details
    Browse the repository at this point in the history
  15. Merge pull request #873 from enthought/maint-tabular-model

    Maint: Normalize row index in TabularModel
    kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    83bec81 View commit details
    Browse the repository at this point in the history
  16. Make sure all UI in tests are disposed (#865)

    * Dispose ui in test_visible_when_layout
    
    * Wrap test with create_ui, and store_exceptions_on_all_threads
    
    * Dispose ui and wrap it under store_exceptions... for test_ui
    
    * Use create_ui in test_color_column
    
    * Wrap tests with create_ui and store_exceptions_on_all_threads
    
    * Dispose ui in test_actions
    
    * Consistently dispose UI with create_ui in test_code_editor
    
    * Skip two tests on wx that fail on its own
    
    * Dispose UI in test_table_editor; these tests are failing on their own
    
    * Remove skips; it was the developer's fault in not refreshing their devenv
    
    * Dispose UI in test_csv_editor
    
    * Make sure dispose must be called in test_date_editor
    
    * Make sure dispose is called in test_date_range_editor
    
    * Make sure dispose is called in test_datetime_editor
    
    * Dispose ui in test_instance_editor
    
    * Dispose ui in test_liststr_editor_selection
    
    * Dispose ui in test_range_editor_spinner
    
    * Dispose ui in test_range_editor_text
    
    * Dispose ui in test_tree_editor
    
    * Dispose UI in test_tuple_editor
    
    * One more in test_data_frame_editor
    
    * Remove additional store_exceptions_on_all_threads as they are orthogonal changes
    
    * Experiment removing skips that were added due to test interactions
    
    * Revert "Experiment removing skips that were added due to test interactions"
    
    This reverts commit 7466c03.
    
    * Try removing another workaround
    
    * Revert "Try removing another workaround"
    
    This reverts commit 090c75c.
    
    * Revert inconsequential change to test_color_column
    
    * Add close back just because it was there before - not sure if it is still needed.
    kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    4e4f39a View commit details
    Browse the repository at this point in the history
  17. Add more TabularEditor tests (#874)

    * Add more tests for Tabular Editor
    
    * Minor wx TabularEditor fix
    
    * Add brief explanation about Rows flag
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    da4264a View commit details
    Browse the repository at this point in the history
  18. Add more ListStrEditor tests (#869)

    * Add more tests for ListStrEditor
    
    * Minor wx ListStrEditor fix
    
    * Add gui.process_events to fix pyface2 errors
    
    * Rename TestListStrEditor with adapter test to TestListStrAdapter
    
    * Add docstrings and clarification comments
    
    * Skip tests on Windows due to potential test interactions
    
    * Fix clear_selection usage
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    de3c6cb View commit details
    Browse the repository at this point in the history
  19. Fix bad TraitListEvent in ListStr and Tabular Editors (#875)

    * Fix bad TraitListEvent in ListStr and Tabular Editors
    
    * Remove test FIXMEs
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    df8b533 View commit details
    Browse the repository at this point in the history
  20. Fix unexpected format_func in RangeEditor bug (#900)

    * Accept format_func, format_str and invalid parameters with RangeEditor
    
    * Add a test to verify same behaviour
    
    * Use kwargs in the signature
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d6d8cf6 View commit details
    Browse the repository at this point in the history
  21. Alternative fix to TabularAdapter crashes when column number reduces (#…

    …897)
    
    Co-authored-by: Federico Miorelli <FedeMiorelli@users.noreply.github.com>
    
    * Fix eerror when the columns number is reduced
    
    * Workaround slot being called after the UI is disconnected
    
    * destroy control (later) in dispose to prevent slots being called after dispose
    
    * Revert "destroy control (later) in dispose to prevent slots being called after dispose"
    
    This reverts commit 8bb6abd.
    
    * Fix issue number in comment
    
    * Update test name and comments
    
    * Rework test comment
    
    * Rewrite comment and run process_events so that bug appears independently of the workaround
    kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    917e152 View commit details
    Browse the repository at this point in the history
  22. Add links from TabularEditor and TreeEditor to adapter docs (#917)

    * Add links from TabularEditor and TreeEditor to adapter docs
    
    * Fix tree node ref
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d720f4d View commit details
    Browse the repository at this point in the history
  23. Fix Theme pickling (#915)

    * Check toolkit before wx import + tests
    
    * Address review comments
    ievacerny authored and kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    fae22ab View commit details
    Browse the repository at this point in the history
  24. Merge pull request #846 from enthought/maint-test-non-null-toolkit-la…

    …yout-labels
    
    TST: Add tests for layout and labels using any non-null toolkits
    (cherry picked from commit 4398b3d)
    kitchoi committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    dde08d2 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    32ef97b View commit details
    Browse the repository at this point in the history