Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all UI in tests are disposed #865

Merged
merged 28 commits into from
Jun 8, 2020
Merged

Make sure all UI in tests are disposed #865

merged 28 commits into from
Jun 8, 2020

Commits on Jun 2, 2020

  1. Dispose ui in test_visible_when_layout

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    0d08875 View commit details
    Browse the repository at this point in the history

  2. Wrap test with create_ui, and store_exceptions_on_all_threads

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    330c4a1 View commit details
    Browse the repository at this point in the history

  3. Dispose ui and wrap it under store_exceptions... for test_ui

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    b8ba2fd View commit details
    Browse the repository at this point in the history

  4. Use create_ui in test_color_column

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    21bea40 View commit details
    Browse the repository at this point in the history

  5. Wrap tests with create_ui and store_exceptions_on_all_threads

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    3afc650 View commit details
    Browse the repository at this point in the history

  6. Dispose ui in test_actions

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    8213d39 View commit details
    Browse the repository at this point in the history

  7. Consistently dispose UI with create_ui in test_code_editor

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    39777d7 View commit details
    Browse the repository at this point in the history

  8. Skip two tests on wx that fail on its own

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    13a3208 View commit details
    Browse the repository at this point in the history

  9. Dispose UI in test_table_editor; these tests are failing on their own

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    68d17f5 View commit details
    Browse the repository at this point in the history

  10. Remove skips; it was the developer's fault in not refreshing their de… 

    …venv
    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    ecbadef View commit details
    Browse the repository at this point in the history

  11. Dispose UI in test_csv_editor

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    9fbfaa1 View commit details
    Browse the repository at this point in the history

  12. Make sure dispose must be called in test_date_editor

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    134019e View commit details
    Browse the repository at this point in the history

  13. Make sure dispose is called in test_date_range_editor

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    6f42cd8 View commit details
    Browse the repository at this point in the history

  14. Make sure dispose is called in test_datetime_editor

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    3483b63 View commit details
    Browse the repository at this point in the history

  15. Dispose ui in test_instance_editor

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    9f123aa View commit details
    Browse the repository at this point in the history

  16. Dispose ui in test_liststr_editor_selection

    @kitchoi
    kitchoi committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    0154662 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Dispose ui in test_range_editor_spinner

    @kitchoi
    kitchoi committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    7862141 View commit details
    Browse the repository at this point in the history

  2. Dispose ui in test_range_editor_text

    @kitchoi
    kitchoi committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    3da92eb View commit details
    Browse the repository at this point in the history

  3. Dispose ui in test_tree_editor

    @kitchoi
    kitchoi committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    6b6d976 View commit details
    Browse the repository at this point in the history

  4. Dispose UI in test_tuple_editor

    @kitchoi
    kitchoi committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    60e80f3 View commit details
    Browse the repository at this point in the history

  5. One more in test_data_frame_editor

    @kitchoi
    kitchoi committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    6fc62fe View commit details
    Browse the repository at this point in the history

  6. Remove additional store_exceptions_on_all_threads as they are orthogo… 

    …nal changes
    @kitchoi
    kitchoi committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    3d7629a View commit details
    Browse the repository at this point in the history

  7. Experiment removing skips that were added due to test interactions

    @kitchoi
    kitchoi committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    7466c03 View commit details
    Browse the repository at this point in the history

  8. Revert "Experiment removing skips that were added due to test interac… 

    …tions"

This reverts commit 7466c03.
    @kitchoi
    kitchoi committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    4d234d0 View commit details
    Browse the repository at this point in the history

  9. Try removing another workaround

    @kitchoi
    kitchoi committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    090c75c View commit details
    Browse the repository at this point in the history

  10. Revert "Try removing another workaround" 

    This reverts commit 090c75c.
    @kitchoi
    kitchoi committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    c2c69a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Revert inconsequential change to test_color_column

    @kitchoi
    kitchoi committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    cf08b84 View commit details
    Browse the repository at this point in the history

  2. Add close back just because it was there before - not sure if it is s… 

    …till needed.
    @kitchoi
    kitchoi committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    cee72da View commit details
    Browse the repository at this point in the history