Feature: expand crosshair on edges #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we like to join two chart with crosshair move together, the join side padding must be zero, otherwise crosshair will be cut like image below:
ps. By adding 50 px bottom padding on top chart.
Solution
By adding
List<bool> expandEdges
, we can decide crosshair expand on left, top, right and bottom directions respectively. Default value is [false, false, false, false]. And only work onRectCoord
. - de0a30bif we add line like this in top chart, we get no-cut crosshair:
Additional fix for show
LabelBackgroundMapper
- 1857d18