-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ds login or ds --version #241
Comments
It's still related to #104 for even node v12 |
https://github.com/entropic-dev/entropic/blob/master/cli/lib/config.js#L21 if you're up to date with master, that error would seem to imply that you have a syntax error in your [registries."https://registry.entropic.dev"]
token = "ent_v1_TOKEN_HERE" Could you post the contents here (with token redacted)? EDIT: I misread the function, it looks like line 28 would mean a syntax error, not 21. To debug, maybe you could log out |
That's is the point actually , I am up to date with master but the point is ~/.entropicrc not theres at all not created |
it trying to load non existing file and dir (the error make sense), the point is where is actual .entropicrc creation |
The file gets created by this function which is called here. Could you add a |
that what i expected and then after logging [Error: EISDIR: illegal operation on a directory, read] { |
Ah okay, so that's saying you have a directory at |
cool it's working now, but suppose that we provide an error for that case ! |
what about changing this with if (e.code === 'ENOENT' || e.code === 'EISDIR') { |
That would still wind up throwing an error in the if (e.code === 'ENOENT') {
return {};
}
if (e.code === 'EISDIR') {
throw new errors.CouldNotReadConfigFile(filename, 'File is a directory!');
}
throw new errors.CouldNotReadConfigFile(filename, e); so that the user can correct the problem. |
@zacanger if you wouldn't mind i will have a PR for it |
…g error fixes in case ther's was a dir or file plus adding logginf error message to Errors
This will make lifes easier since it's handling everything in sync. Also modified error messages. |
Bug
Expected behavior:
redirect to login with github
Actual behavior:
Error: /Users/$USRNAME/.entropicrc
at load (/usr/local/lib/node_modules/ds/lib/config.js:21:11)
Environment info (where relevant)
OSX 10.14.5
node -v
):v12.4.0
ds --version
):error
at load (/usr/local/lib/node_modules/ds/lib/config.js:21:11)
The text was updated successfully, but these errors were encountered: