Cascade -e files when combined with -c #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `-e` and `-c` together we should load the .<env> and .local versions of the files specified by `-e`. Note that this is a change from the behavior introduced in ba7c7ba (v3.2.0) when combining `-e extra` with `-c` would result in processing: [ '.env.local', '.env', 'extra' ] It will now process: [ 'extra.local', 'extra' ]
davecardwell
changed the title
entropitor
approved these changes
Sep 10, 2020
Co-authored-by: Jens Claes <jensclaes33@gmail.com> Fix variable name
|
Released as v4.0.0 |
Merged
1 task
This was referenced May 23, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that when combining the
-cand-eflags it is the extra files that will get the .local and environment specific versions. This is a change from the current behavior which cascades to.env.local,.env,extraso this may necessitate a major version bump, but I think is a more consistent behavior.To demonstrate…
[ '.env' ][ '.env' ]-c[ '.env.local', '.env' ][ '.env.local', '.env' ]-c foo[ '.env.foo.local', '.env.foo', '.env.local', '.env' ][ '.env.foo.local', '.env.foo', '.env.local', '.env' ]-e bar[ 'bar' ][ 'bar' ]-c -e bar[ '.env.local', '.env', 'bar' ][ 'bar.local', 'bar' ]-c foo -e bar[ '.env.foo.local', '.env.foo', '.env.local', '.env', 'bar' ][ 'bar.foo.local', 'bar.foo', 'bar.local', 'bar' ]I also added a
--debugflag to make it easier to see what filesdotenv-cliwill process.Fixes #43