Add oracle data pointer check #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameba23
approved these changes
Dec 5, 2024
| @@ -22,6 +22,7 @@ sp-std ={ version="14.0.0", default-features=false } | |||
| smallvec="1.13.2" | |||
|
|
|||
| pallet-balances={ version="29.0.0" } | |||
| pallet-oracle ={ version='0.3.0', path='../oracle', default-features=false } | |||
There was a problem hiding this comment.
This is needed because the oracle config is now part of the programs config, and programs is a dependency of transaction-pause right?
ameba23
reviewed
Dec 5, 2024
| @@ -218,10 +218,14 @@ pub mod pallet { | |||
| ProgramAlreadySet, | |||
| /// User owns too many programs. | |||
| TooManyProgramsOwned, | |||
| /// Program is being used by an account | |||
| /// Program is being used by an account. | |||
There was a problem hiding this comment.
I think adding these is gonna make @HCastano happy
There was a problem hiding this comment.
yes, why I did it, but I also rolled my eyes while doing it
ameba23
added a commit
that referenced
this pull request
Dec 9, 2024
* master: Bump thiserror from 2.0.4 to 2.0.6 in the patch-dependencies group (#1206) Downgrade parity-scale-codec as version we currently use has been yanked (#1205) Bump clap from 4.5.22 to 4.5.23 in the patch-dependencies group (#1202) Add oracle data pointer check (#1194) Bump tokio from 1.41.1 to 1.42.0 (#1196) Allow offchain worker requests to all TSS nodes in `entropy-tss` test environment (#1147) Bump the patch-dependencies group with 3 updates (#1195)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1166