-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoints to migrate an encrypted key-value store dump for upgrading entropy-tss
#1259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* peg/recovery-feature: Fix for building entropy-shared for wasm
* peg/recovery-feature: Fix staking pallet benchmarks Fix staking pallet mock
* peg/recovery-feature: Flatten HTTP API structure following review Clippy Minor edits from PR review Rename struct field following review Use sp_core::crypto::AccountId32 as key for hashmap to be more explicit Fix client tests Fix attestation pallet tests
* peg/recovery-feature: Add an extra TSS state for connected to chain but not funded / fully ready (#1263)
@JesseAbram @HCastano as it looks like we maybe don't want this, i am thinking to close it for now and possibly re-open later if we do a version upgrade runthrough and find that it is a problem that all TSS nodes change their IDs. |
Closing re: comment above #1259 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to, #1247 and is described in this comment: #1247 (comment)
This provides HTTP endpoints which allow us to export the key-value store as a raw encrypted key-value pair dump, and import it again on a new version of entropy-tss.
The workflow will be something like:
/backup_encrypted_db
to get a payload containing the encrypted db, as well as details of the 'key provider'.entropy-tss
/backup_encrypted_db
giving the payload from step 1 in the request body, which would put the db / key provider files back. This route can only be used when the node is in a 'not yet ready' state.Currently based off #1249
Following core sync call - it seems like we maybe don't want or need this feature.