Release `v0.0.10` #605

HCastano · 2024-01-24T03:30:38Z

One thing to note here - the pallet_treasury benchmarks fail to run. I've excluded updating them because I don't want to block the release that, but we should follow up with this.

❯ ./target/release/entropy benchmark pallet \
    --chain dev \
    --wasm-execution=compiled \
    --pallet pallet_treasury \
    --extrinsic "*" \
    --steps 5 \
    --repeat 2 \
    --template .maintain/frame-weight-template.hbs \
    --output ./treasury_weights.rs
2024-01-23 20:27:48 [0] 💸 generated 2 npos voters, 2 from validators and 0 nominators
2024-01-23 20:27:48 [0] 💸 generated 2 npos targets
2024-01-23 20:27:49 Starting benchmark: pallet_treasury::spend_local
2024-01-23 20:27:49 WARNING: benchmark weightless skipped - spend_local
2024-01-23 20:27:49 WARNING: benchmark weightless skipped - spend_local
2024-01-23 20:27:49 WARNING: benchmark weightless skipped - spend_local
2024-01-23 20:27:49 Starting benchmark: pallet_treasury::propose_spend
2024-01-23 20:27:49 Starting benchmark: pallet_treasury::reject_proposal
2024-01-23 20:27:49 Starting benchmark: pallet_treasury::approve_proposal
2024-01-23 20:27:49 Starting benchmark: pallet_treasury::remove_approval
2024-01-23 20:27:49 Starting benchmark: pallet_treasury::on_initialize_proposals
2024-01-23 20:27:49 Starting benchmark: pallet_treasury::spend
2024-01-23 20:27:49 WARNING: benchmark weightless skipped - spend
2024-01-23 20:27:49 WARNING: benchmark weightless skipped - spend
2024-01-23 20:27:49 WARNING: benchmark weightless skipped - spend
Error: Input("Benchmark pallet_treasury::payout failed: No origin")
2024-01-23 20:27:49 Starting benchmark: pallet_treasury::payout

An exception here is `pallet_treasury`, whose benchmarks are failing right now for some reason.

vercel · 2024-01-24T03:30:40Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
entropy-core	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 24, 2024 3:56am

HCastano · 2024-01-24T03:33:08Z

CHANGELOG.md

+
+Finally, users are now able to indicate which hashing algorithm they would like to use during the
+signing step. We provide some common ones out of the box, but custom user-provided hashing
+algorithms are also supported.

 ### Breaking Changes


Jesse and Peg, I removed a couple things in here because while the did break the API between PRs, they didn't break something that existed in v0.0.9.

ameba23

💯

assuming updating the treasuring benchmarks later is not going to cause problems (can't see why it would).

ameba23 · 2024-01-24T10:47:06Z

crates/threshold-signature-server/entropy_metadata.scale

It this metadata re-build relating to #598 or is it something to do with doing the benchmarks here?

It has to do with the changes to the spec_version and transaction_version

ameba23 · 2024-01-24T10:49:27Z

scripts/benchmarks.sh

@@ -1,5 +1,7 @@
 #!/bin/bash

+set -eux


what does this do?

This adds some extra checks (e.g unbound variables) and printing (e.g values of variables) when running a Bash script.

In this case I was interested in seeing what packages were being used as part of the benchmark array - and it turned out the array was empty!

The output can be a bit annoying, but since we're not running the script that often I think it's alright. I can also remove this from the committed code and just add it locally when needed if anyone complains lol

ameba23 · 2024-01-24T10:58:43Z

crates/threshold-signature-server/Cargo.toml

@@ -34,7 +34,7 @@ axum       ={ version="0.6.18", features=["ws"] }
 axum-macros="0.3.7"

 # Substrate
-subxt             ={ package="subxt", git="https://github.com/paritytech/subxt.git", tag="v0.32.1" }


Not strictly related to this PR, but if moving from git dependencies to crates.io dependencies is because of wanting to be able to publish to crates.io ourselves: we have hex = "*" here and wildcards like that are not allowed on crates.io. (without wanting to get into the discussion about whether we should publish to crates.io)

without wanting to get into the discussion about whether we should publish to crates.io

Actually that's a good point. Most packages right now should be in a publishable state. For the TSS server I think the only other thing we need here is for Jake to publish Programs to crates.

We can totally aim to do that for this release.

Wdyt @jakehemmerle @JesseAbram

Talked to Jake, gonna do this in the next release

JesseAbram

I may be missing it but I don't think the TSS version is updated

HCastano · 2024-01-24T15:25:09Z

assuming updating the treasuring benchmarks later is not going to cause problems (can't see why it would).

Right now it's not a problem because we're not really running benchmarks properly anyways. If, for example, we had our reference benchmark machine set up and they failed there - yes that would be a problem.

I may be missing it but I don't think the TSS version is updated

For now I have not been updating the versions of packages which we intend to publish, which include the TSS server version. Once we start publishing on crates then we can bump those

JesseAbram · 2024-01-24T15:28:58Z

For now I have not been updating the versions of packages which we intend to publish, which include the TSS server version. Once we start publishing on crates then we can bump those

I don't love it, gonna approve but my argument here is the tss should be fast forwarded and follow the chain versioning since it would be cleaner and would make a lot more sense especially in the changelog. I also don't think we should be changing our behaviour here for crates.

HCastano · 2024-01-24T15:38:18Z

I don't love it, gonna approve but my argument here is the tss should be fast forwarded and follow the chain versioning since it would be cleaner and would make a lot more sense especially in the changelog. I also don't think we should be changing our behaviour here for crates.

I don't totally disagree with you here, but the release cadence of each could be quite different. We could publish updates to the server which don't affect on-chain interactions, but may have breaking changes to the publicly exposed API for example.

This is worth a longer discussion for sure.

HCastano added 12 commits January 23, 2024 18:41

Use published subxt version instead of Git one

0f89576

Add link to diff between last release and master to CHANGELOG

9422dca

Bump spec_version and transaction_version

b8cf290

Bump crate versions to 0.0.10

e283b2e

Bump Cargo.lock

24160d8

Bump metadata

5ea6e14

Clean up some of the Breaking Changes descriptions

1bc2a1c

Build node when running benchmarks

1c6b46c

Have diff links show commit list instead of files

b27143e

Add blurb to release notes

0f6ace0

Actually, let's not build the node on every benchmark

97c277a

Update all runtime weights

4c2acdd

An exception here is `pallet_treasury`, whose benchmarks are failing right now for some reason.

HCastano commented Jan 24, 2024

View reviewed changes

HCastano requested review from ameba23 and JesseAbram January 24, 2024 03:35

vercel bot deployed to Preview January 24, 2024 03:56 View deployment

ameba23 approved these changes Jan 24, 2024

View reviewed changes

ameba23 reviewed Jan 24, 2024

View reviewed changes

JesseAbram requested changes Jan 24, 2024

View reviewed changes

JesseAbram self-requested a review January 24, 2024 15:29

JesseAbram approved these changes Jan 24, 2024

View reviewed changes

HCastano merged commit a9463b0 into master Jan 24, 2024
14 checks passed

HCastano deleted the hc/release-v0.0.10 branch January 24, 2024 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release `v0.0.10` #605

Release `v0.0.10` #605

HCastano commented Jan 24, 2024 •

edited

Loading

vercel bot commented Jan 24, 2024 •

edited

Loading

HCastano Jan 24, 2024

ameba23 left a comment

ameba23 Jan 24, 2024

HCastano Jan 24, 2024

ameba23 Jan 24, 2024

HCastano Jan 24, 2024

ameba23 Jan 24, 2024

HCastano Jan 24, 2024

HCastano Jan 24, 2024

JesseAbram left a comment

HCastano commented Jan 24, 2024

JesseAbram commented Jan 24, 2024

HCastano commented Jan 24, 2024

Release v0.0.10 #605

Release v0.0.10 #605

Conversation

HCastano commented Jan 24, 2024 • edited Loading

vercel bot commented Jan 24, 2024 • edited Loading

Choose a reason for hiding this comment

ameba23 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JesseAbram left a comment

Choose a reason for hiding this comment

HCastano commented Jan 24, 2024

JesseAbram commented Jan 24, 2024

HCastano commented Jan 24, 2024

Release `v0.0.10` #605

Release `v0.0.10` #605

HCastano commented Jan 24, 2024 •

edited

Loading

vercel bot commented Jan 24, 2024 •

edited

Loading