Integrate oracle to programs #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2024
ameba23
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
💯 All looks good.
What kind of location could oracle_data_pointer be? If i've understood right, before evaluating a program, a TSS server will make a query to the chain using oracle_data_pointer and use the output as the final argument to runtime.evaluate(). But i don't know how oracle_data_pointer would be formatted.
ameba23
added a commit
that referenced
this pull request
Apr 30, 2024
* master: Integrate oracle to programs (#788)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pairs with entropyxyz/programs#72 as it updates the new runtime for the oracle data, until we are ready to integrate the oracle data None is passed through to the program interface