Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device Key Proxy Program #62

Merged
merged 20 commits into from
Mar 22, 2024
Merged

Device Key Proxy Program #62

merged 20 commits into from
Mar 22, 2024

Conversation

jakehemmerle
Copy link
Contributor

#58

@vercel Vercel
Copy link

vercel bot commented Mar 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
programs ❌ Failed (Inspect) Mar 22, 2024 7:19pm

@frankiebee
Copy link

frankiebee commented Mar 14, 2024 •
edited by JesseAbram
Loading

  • should account for different key types (start with basics: sr25519, ed25519, secp256k1 ecdsa ✔️ )
  • types should be stored in config and passed in as aux_data
  • instead of verfiying against each key have the public_key passed in as aux_data and check against the signed message and then check against config allowed keys

@jakehemmerle jakehemmerle marked this pull request as ready for review March 20, 2024 21:11
frankiebee
frankiebee approved these changes Mar 22, 2024
View reviewed changes
Copy link

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fly as fuck brah

@JesseAbram JesseAbram merged commit 234f491 into master Mar 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankiebee frankiebee frankiebee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakehemmerle @frankiebee @JesseAbram